Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed help center to integrate with frontend #897

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

JoshuaOloton
Copy link
Contributor

@JoshuaOloton JoshuaOloton commented Aug 15, 2024

Description

Resolved issues with the help center endpoints that were not processing correctly. Also fixed the Help Center GET filter endpoint by removing the request body and corrected the placement of the topic ID.

Related Issue (Link to issue ticket)

#960
hngprojects/hng_boilerplate_nestjs#951

Motivation and Context

These changes are necessary to ensure the help center endpoints function correctly. The changes address the incorrect processing of requests, eliminates the request bodies in the GET filter endpoint, and corrects the placement of the topic ID.

How Has This Been Tested?

Unit tests were written and carried out for this endpoint using the Pytest library.

Screenshots (if appropriate - Postman, etc):

SWAGGER UI

Screenshot (1023)

UPDATE HELP CENTER TOPIC

Screenshot 2024-08-15 144112

FILTER HELP CENTER TOPICS

Screenshot 2024-08-15 144008

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Goketech Goketech merged commit d807d9d into hngprojects:dev Aug 15, 2024
1 check passed
@JoshuaOloton JoshuaOloton deleted the fix/help-center branch August 24, 2024 08:42
@JoshuaOloton JoshuaOloton restored the fix/help-center branch August 24, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants